Skip to content

Conversation

@tekenstam
Copy link
Member

Description

This PR implements the updates described in issue #459 to upgrade the instance-manager project to Go 1.24.

Changes

  • Updated Go version to 1.24 with toolchain go1.24.1 in go.mod
  • Updated Dockerfile to use golang:1.24 as the base image
  • Updated GitHub workflows to use Go 1.24
  • Modified controller-gen installation process to use v0.14.0 for better compatibility with Go 1.24 and ARM architectures
  • Reorganized GitHub issue templates to improve the contribution experience

Testing

  • Verified project builds successfully with Go 1.24
  • Generated manifests with the updated controller-gen version
  • All tests are passing

Checklist

  • I have updated relevant documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have signed my commits with git commit -s for DCO
  • I have run make to ensure the codebase builds with my changes

Fixes #459

@tekenstam tekenstam requested review from a team as code owners April 13, 2025 00:11
Copy link

@shaoxt shaoxt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.99%. Comparing base (a31734e) to head (1e6e2fd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
- Coverage   50.11%   44.99%   -5.13%     
==========================================
  Files          34       40       +6     
  Lines        6299     7017     +718     
==========================================
  Hits         3157     3157              
- Misses       2993     3711     +718     
  Partials      149      149              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tekenstam tekenstam merged commit c2a3dea into master Apr 13, 2025
3 checks passed
@tekenstam tekenstam deleted the update-go-1.24 branch April 13, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to Go 1.24

5 participants