fix(types): normalize ArrayBuffer/Uint8Array conversions #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypeScript typings
…tes at API boundaries; test fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix TypeScript compile errors caused by passing Uint8Array where ArrayBuffer is expected and mismatched Buffer.from overloads.
Changes:
Convert Uint8Array results of CryptoEngine.random, base64ToBytes, etc. to ArrayBuffer when assigning to ArrayBuffer-typed fields or passing to functions that expect ArrayBuffer (use arrayToBuffer helper).
Use Uint8Array (not ArrayBuffer) when calling Buffer.from to satisfy Node typings.
Files touched: byte-utils.ts, lib/crypto/, lib/format/.
Verification: Ran the project's header-dump script which previously failed; it now prints header info and the TypeScript compile step succeeds.