toJSON implementation for createPublicKeyCredential #2613
+64
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keroosha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2298
createPublicKeyCredentialdoesn't implement toJSON method from PublicKeyCredential prototype PublicKeyCredential: toJSON method at developer.mozilla.orgThis PR implements that method by manually mapping
PublicKeyCredentialJSONmodelTesting strategy
Repro at webauthn-tojson.cybergulag.today
I patched Webauthn.NET demo to use
PublicKeyCredential.toJSONmethod oncompleteAuthenticationandcompleteRegistrationstepsWebAuthn.NET lib.js
Passwordless and Usernameless flow should work fine on PR version
1.9.9.1 release will fail on missing toJSON method as mentioned in #2298
Type of change