-
Notifications
You must be signed in to change notification settings - Fork 0
fix: trailing open block comment #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4b5076f
80abd6f
79405f4
75608b1
79a471b
474d064
a101cec
a2d6fe7
da5373d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,5 @@ | ||
language: php | ||
php: | ||
- 5.6 | ||
- 5.5 | ||
- 5.4 | ||
- 5.3 | ||
- hhvm | ||
|
||
script: phpunit --coverage-text |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
<?php | ||
|
||
ini_set('display_errors', true); | ||
ini_set('error_reporting', E_ALL); |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -214,7 +214,7 @@ protected static function getNextToken($string, $previous = null) | |
} | ||
|
||
// Comment | ||
if ($string[0] === '#' || (isset($string[1])&&($string[0]==='-'&&$string[1]==='-') || ($string[0]==='/'&&$string[1]==='*'))) { | ||
if ($string[0] === '#' || (isset($string[1])&&($string[0]==='-'&&$string[1]==='-') || ($string[0]==='/'&&isset($string[1])&&$string[1]==='*'))) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. whitespace? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. chtěl jsem držet aktuální coding style. kdybychom tu knihovnu adoptovali, tak bych to doladil, ale do tý doby se snažím zdržet coding style změn. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no tak mas tam There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. jj, ale to jsem neměnil, přidával jsem jen |
||
// Comment until end of line | ||
if ($string[0] === '-' || $string[0] === '#') { | ||
$last = strpos($string, "\n"); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tak to muzes rovnou vyhodit aji tu 5.4 a 5.5 ne?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 bohužel 7.0+ nešlape a to teď vůbec nechci řešit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no to bych taky neresil