Skip to content

Conversation

amyXia1994
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/service/rest_server.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

minor: add GetSchemaTypeMapping rest api

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@amyXia1994 amyXia1994 requested a review from Peefy September 14, 2023 12:02
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6185123685

  • 1 of 6 (16.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 64.605%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/service/rest_server.go 1 6 16.67%
Totals Coverage Status
Change from base Build 6183142622: -0.07%
Covered Lines: 2612
Relevant Lines: 4043

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 5d0d984 into kcl-lang:main Sep 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
@amyXia1994 amyXia1994 deleted the minor/add-GetSchemaTypeMapping-rest-api branch September 15, 2023 02:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Go API for GetSchemaTypeMapping
3 participants