Fix [BUG] Unexpected node test
#30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leila-alderman
added a commit
to activemerchant/active_merchant
that referenced
this pull request
May 13, 2020
Updated the supported Ruby and Rails versions to remove versions that have officially been moved to end of life while maintaining support for versions 5.0 and 5.1 for Rails. - Removed Ruby versions 2.3 and 2.4 - Added Ruby versions 2.6 and 2.7 - Removed Rails version 4.2 - Added Rails version 6.0 In addition, the following changes were made as part of this update: - RuboCop target Ruby version was updated to 2.5, which necessitated some RuboCop fixes in various files - The RuboCop version was upgraded to 0.83, which necessitated even more RuboCop fixes in various files - [Fix an REXML error](kbeckman/omniauth-wsfed#30) for the So Easy Pay gateway - Add in missing Active Support core extensions to the test helper file All unit tests: 4497 tests, 71905 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error started to raise when we migrated our project to
Rails 5.2.3 & Ruby 2.6.3.Adding
*before[fixed this issue for us.