Use mcp tools for filter chain #621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
adilhafeez
changed the title
adilhafeez
changed the title
- Update request.rs to handle new MessageContent enum structure from main - MessageContent can now be Text(String) or Items(Vec<InputContent>) - Handle new InputItem variants (ItemReference, FunctionCallOutput) - Fixes compilation error after merging latest main (#632)
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
| "--agent", | ||
| "agent", | ||
| required=True, | ||
| help="Agent name: query_rewriter, context_builder, or response_generator", |
Contributor
There was a problem hiding this comment.
Are we mixing agents and filters in the MCP server. That will be confusing for the reader, because we want to drive a distinction between an agent that does "work" and filters are intended to "mutate" requests. Plus in our config they are separate things, and in this example they are combinned.
salmanap
reviewed
Dec 17, 2025
salmanap
reviewed
Dec 17, 2025
Contributor
salmanap
left a comment
salmanap
left a comment
There was a problem hiding this comment.
Have a few comments. Feel free to call me so that we can start resolving these. Major themes
- Trace building isn't ideal. Don't understand the diff between MCP spans and others.
- We are re-building alot of the sse parsing logic by hand again
- We don't seem to be getting the agent description via MCP (i couldn't tell if we were).
- Config suggestions.
salmanap
pushed a commit
that referenced
this pull request
Dec 17, 2025
Contributor
Author
|
going to merge this change since same tests are broken in main |
salmanap
pushed a commit
that referenced
this pull request
Dec 24, 2025
* agents framework demo * more changes * add more changes * pending changes * fix tests * fix more * rebase with main and better handle error from mcp * add trace for filters * add test for client error, server error and for mcp error * update schema validate code and rename kind => type in agent_filter * fix agent description and pre-commit * fix tests * add provider specific request parsing in agents chat * fix precommit and tests * cleanup demo * update readme * fix pre-commit * refactor tracing * fix fmt * fix: handle MessageContent enum in responses API conversion - Update request.rs to handle new MessageContent enum structure from main - MessageContent can now be Text(String) or Items(Vec<InputContent>) - Handle new InputItem variants (ItemReference, FunctionCallOutput) - Fixes compilation error after merging latest main (#632) * address pr feedback * fix span * fix build * update openai version
salmanap
pushed a commit
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.