Add support for mingw toolchain in Windows #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_MSC_VER is defined in MSVC toolchain only whereas _WIN32 is defined for all toolchain targeting Windows. See https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros
This fixes compiler errors as following with cmake and mingw compiler. cava/output/sdl_glsl.c:9:10: fatal error: output/sdl_glsl.h: No such file or directory 9 | #include "output/sdl_glsl.h" | ^~~~~~~~~~~~~~~~~~~ compilation terminated.
This fixes the following compiler error with mingw compiler.
cava/output/sdl_glsl.c:89:16: error:
passing argument 1 of 'printf' from incompatible pointer type [-Wincompatible-pointer-types]
89 | printf(stderr, "Error initializing GLEW! %s\n", glewGetErrorString(glewError));
| ^~~~~~
| |
| FILE * {aka struct _iobuf *}
This fixes the following compiler error with mingw compiler.
cava/cava.c:258:32: error:
passing argument 1 of 'SetConsoleCtrlHandler' from incompatible pointer type [-Wincompatible-pointer-types]
258 | if (!SetConsoleCtrlHandler(sig_handler, TRUE)) {
| ^~~~~~~~~~~
| |
| void (*)(int)
Contributor
Author
|
tl;dr The changes are not due to mingw toolchain. These fix the assumptions and mistakes with Microsoft Visual Studio compiler. |
Owner
|
nice! yes the windows support was thrown together sitting in visual studio, didn't really expect it to catch on. Maybe the cmake could be expanded to be used in visual studio as well and get rid of some of the hardcoded project files. Not sure how to do the nuget stuff though. |
Contributor
Author
|
With these changes, cava is now in msys2/mingw repository https://packages.msys2.org/base/mingw-w64-cava |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.