6.0: allow expect in webauthn-authenticator-rs, and in all tests#540
Merged
Firstyear merged 1 commit intokanidm:6.0-dev-drop-opensslfrom Feb 17, 2026
Merged
Conversation
40 tasks
Member
|
How many uses of expect are there in the non-test code? normally we just allow-list them on a case-by-case basis to indicate it's been checked etc. Test code it's fine to use, since it gives feedback unlike unwrap 😄 |
Firstyear
approved these changes
Feb 17, 2026
Member
Firstyear
left a comment
There was a problem hiding this comment.
Yep, this is fine shortterm.
7e74fb6
into
kanidm:6.0-dev-drop-openssl
19 of 35 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
masterbranch currently allowsexpect()to be used anywhere, but the 6.0 branch doesn't.In the longer term, we should fix these.
But denying
expect()currently triggers CI build failures with certain features enabled (cable,mozilla,softtoken,ui-cli,win10), which aren't enabled by default.Some of these uses will be addressed as we rewrite to drop OpenSSL support for #499, but with
clippybeing an early step in CI, additional failures make it impossible to measure progress using the CI build matrix (ie: feature combinations becoming or returning to green).I've also allowed
expect()in tests, likeunwrap()is allowed. Usingexpect()orunwrap()gives us stack traces for unexpected errors in tests, so it's much easier to trace how a test broke.This takes us from 11/35 to 19/35 passing tests.