Skip to content

Bump omniauth and omniauth-github #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 29, 2021

⚠️ Dependabot is rebasing this PR ⚠️

If you make any changes to it yourself then they will take precedence over the rebase.


Bumps omniauth and omniauth-github. These dependencies needed to be updated together.
Updates omniauth from 1.9.1 to 2.0.3

Release notes

Sourced from omniauth's releases.

Fix rescuing of application errors when call_app! is used.

As a consequence of the changes that were merged in #689, errors thrown by strategies that utilize other_phase (or more specifically call_app!), would be caught by omniauth, causing headaches for folks looking to have those errors handled by their application. This should allow for errors that come from the app to pass through, while passing errors that come from the authentication phases to the fail! handler.

Resolves #1030

Fix for incorrect order of request_validation_phase in test_mode.

@​jsdalton gave an awesome report of the issue present in test_mode in #1033

The current implementation of mock_call was verifying the token for all requests, regardless of whether the current path is on the omniauth request path. The change was introduced recently in 1b784ff. See #1032 for details.

This creates two problems:

  1. When test mode is on, the authenticity verification logic is run inappropriately against requests where this may not even be wanted.
  2. The behavior varies from actual production behavior, potentially allowing bugs to be introduced by unwary developers.

Note that this bug was only present when OmniAuth was configured for test_mode and using the mock_call phases.

Allow passing rack-protection configuration to default request_validation_phase

This release now properly allows an instance of OmniAuth::AuthenticityTokenProtection (with passed in rack-protection configuration) to be used as the request_validation_phase.

Thanks @​jkowens #1027

If you haven't already read the release notes for v2.0.0, you should do so.

v2.0.0

Version 2.0 of OmniAuth includes some changes that may be breaking depending on how you use OmniAuth in your app.

Many thanks to the folks who contributed in code and discussion for these changes.

OmniAuth now defaults to only POST as the allowed request_phase method.

Hopefully, you were already doing this as a result of the warnings due to CVE-2015-9284.
For detailed context, see:
#960
#809
Resolving CVE-2015-9284

This change also includes an additional configurable phase: request_validation_phase.

Rack/Sinatra

By default, this uses rack-protection's AuthenticityToken class to validate authenticity tokens. If you are using a rack based framework like sinatra, you can find an example of how to add authenticity tokens to your view here.

Rails

Because Rails handles its CSRF protection in its RequestForgeryProtection class, and stores tokens in a non-vanilla-rack friendly way, you must pass a rails-friendly validator in instead, similar to what omniauth-rails_csrf_protection does.

Update: omniauth-rails_csrf_protection has released v1.0.0, which means if you're using this library already, you should be able to upgrade omniauth to the 2.0 series as long as omniauth-rails_csrf_protection is also upgraded '~> 1.0'

... (truncated)

Commits
  • f9dddef v2.0.3 release
  • 7e1b49f Merge pull request #1035 from omniauth/1030-standard-error-handling
  • 6f4cdb0 Better handle errors that come from the actual app.
  • 0d533c3 Update README for next dev cycle.
  • ba115e1 Prepare for 2.0.2 release
  • 6c822c0 Merge pull request #1033 from jsdalton/fix-mock-call
  • 04187da Ensure mock call verifies authenticity tokens with same logic as real call
  • 40e354c Prepare for next development phase.
  • 982d1e4 Release 2.0.1
  • b55ad4c Merge pull request #1027 from jkowens/patch-1
  • Additional commits viewable in compare view

Updates omniauth-github from 1.4.0 to 2.0.0

Release notes

Sourced from omniauth-github's releases.

Require OmniAuth 2.0.0

As of v2.0.0 of this gem, it will require OmniAuth 2.0.0. This is due to changes that came with OmniAuth that required a breaking change in this gem. Because we changed the strategy's code, you should not need to change any omniauth-github specific code.

You should refer to OmniAuth's v2.0.0 release and/or the v2.0 upgrade guide when upgrading OmniAuth to v2.0.

Commits
  • 1f77226 Merge pull request #95 from BobbyMcWho/chores-2020-01-12
  • 7e5bcd8 Release 2.0.0
  • f12d90f Allow for omniauth 2.0 series
  • 5afe8ae Merge pull request #92 from Anthonyntilelli/patch-1
  • 4547b90 Merge pull request #93 from mikong/docs/github-docs-readme
  • 24480cd Update link to GitHub Docs in README
  • 267f54b udate readme for rails usage
  • d001ed2 Add semver notice.
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Mar 29, 2021
Bumps [omniauth](https://github.com/omniauth/omniauth) and [omniauth-github](https://github.com/intridea/omniauth-github). These dependencies needed to be updated together.

Updates `omniauth` from 1.9.1 to 2.0.3
- [Release notes](https://github.com/omniauth/omniauth/releases)
- [Commits](omniauth/omniauth@v1.9.1...v2.0.3)

Updates `omniauth-github` from 1.4.0 to 2.0.0
- [Release notes](https://github.com/intridea/omniauth-github/releases)
- [Commits](omniauth/omniauth-github@v1.4.0...v2.0.0)

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/omniauth-and-omniauth-github-2.0.3 branch from 4a42528 to 458d6bc Compare March 29, 2021 22:57
@kakikubo kakikubo merged commit 09da978 into develop Mar 30, 2021
@kakikubo kakikubo deleted the dependabot/bundler/omniauth-and-omniauth-github-2.0.3 branch March 30, 2021 00:06
@github-actions github-actions bot mentioned this pull request Mar 30, 2021
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant