-
-
Notifications
You must be signed in to change notification settings - Fork 150
FE: Column Filtering Support for Kafka connects table #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vixtir
wants to merge
10
commits into
main
Choose a base branch
from
table_filters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+773
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leshe4ka
approved these changes
Jun 28, 2025
fallen-up
reviewed
Jun 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need rename folder FIlter to Filter to (frontend/src/components/common/NewTable/Filter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
What’s Added
Extended column meta definition for TanStack Table with a new property:
meta.filterVariant?: 'multi-select'
Added support for column-level filtering based on filter variant.
How to Enable Filtering for a Column
A column that supports filtering must define:
accessorKey
meta.filterVariant
e.g. 'multi-select'filterFn
(e.g. 'arrIncludesSome')Example
URL Filter Persistence
Introduced
queryPersister
to sync filters with the URL.This avoids polluting the main Table component with filter state management logic.
Columns filtering Persistence logic is extracted into
Filter/lib/persister
module.All persisters implement the following interface:
The approach is scalable — new filter variants or persisters (e.g., localStorage, session, or in-memory) can be added with minimal changes.
Pagination can optionally be reset on filter change via the resetPagination argument.
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)