Fix install script raspi cmdline message #12842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
requested changes
Aug 28, 2025
brandond
previously approved these changes
Aug 28, 2025
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #12842 +/- ##
===========================================
- Coverage 40.90% 20.72% -20.19%
===========================================
Files 187 185 -2
Lines 19067 19014 -53
===========================================
- Hits 7799 3940 -3859
- Misses 10088 14636 +4548
+ Partials 1180 438 -742
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
manuelbuil
previously approved these changes
Aug 28, 2025
|
I believe there's a flaky test 😅 |
Signed-off-by: Zachary Spar <[email protected]>
Updated SHA256 checksum for install.sh Signed-off-by: Zachary Spar <[email protected]>
dereknola
force-pushed
the
spar/install-error-msg
branch
from
808e676 to
fcada1d
Compare
brandond
approved these changes
Sep 19, 2025
manuelbuil
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Updated the error message for memory cgroup detection to reflect the correct location of the
cmdline.txtfile on Raspberry Pi systems running Raspberry Pi OS Bookworm or later (released in 2023). The file path has changed from/boot/cmdline.txtto/boot/firmware/cmdline.txtdue to the new firmware structure introduced in Raspberry Pi OS Bookworm.Types of Changes
Docs
Verification
The change can be verified by:
cgroup_memory=1 cgroup_enable=memoryin the kernel command line)./boot/firmware/cmdline.txtinstead of/boot/cmdline.txt./boot/firmware/directory.Testing
This change is a minor text update to an error message and does not affect the core functionality of k3s. Existing integration tests for cgroup detection should suffice, as the change only modifies the displayed file path. No new tests are required, but manual verification on a Raspberry Pi running Bookworm can confirm the updated message appears as expected.
Linked Issues
None
User-Facing Change
Further Comments
This change corrects an outdated file path in the error message, addressing confusion for Raspberry Pi users on Bookworm or later, where boot configuration files moved to
/boot/firmware/. The fix is straightforward, aligning the error message with the current Raspberry Pi OS filesystem. No alternative approaches were considered, as this directly resolves the issue.