Add version to the status of K0smotronControlPlane#826
Merged
makhov merged 1 commit intok0sproject:mainfrom Nov 25, 2024
Merged
Add version to the status of K0smotronControlPlane#826makhov merged 1 commit intok0sproject:mainfrom
makhov merged 1 commit intok0sproject:mainfrom
Conversation
apedriza
reviewed
Nov 25, 2024
Contributor
apedriza
left a comment
apedriza
left a comment
There was a problem hiding this comment.
I think we need to change to version instead string as field value and generate it again. Otherwise it will display:
| ExternalManagedControlPlane bool `json:"externalManagedControlPlane"` | ||
| Ready bool `json:"ready"` | ||
| ControlPlaneReady bool `json:"controlPlaneReady"` | ||
| Version string `json:"string"` |
Contributor
There was a problem hiding this comment.
Suggested change
| Version string `json:"string"` | |
| Version string `json:"version"` |
Contributor
Author
There was a problem hiding this comment.
Heh, great catch, thanks! Fixed
Signed-off-by: Alexey Makhov <amakhov@mirantis.com>
makhov
force-pushed
the
k0smotron-cluster-version
branch
from
19ef6c4 to
71708c6
Compare
apedriza
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #819