fix: support all Ignition spec versions during provisioning#1346
Open
fix: support all Ignition spec versions during provisioning#1346
Conversation
Signed-off-by: apedriza <adripedriza@gmail.com>
apedriza
force-pushed
the
fix-ignition-for-any-version
branch
from
8b7b4e5 to
c7c5fba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignition config was always generated for 3.4 version spec. Some variant versions for the butane config used to generate the ignition config may generate other ignition spec versions (see map table).
With this change, we make use of
ignition.config.mergefeature to merge basic butane config generated for machine bootstrapping + the additional butane config the user can set and generate the proper ignition spec version.For additional context, merging butane configs is not implemented by butane package so we rely on the merge feature of the ignition config once basic and additional butane configs has been transpiled.
Also added an e2e example using Fedora CoreOS for machine nodes