Skip to content

remove webhook checker deploy in inttest#1310

Merged
apedriza merged 1 commit intok0sproject:mainfrom
apedriza:remove-webhook-checker-inttest
Dec 4, 2025
Merged

remove webhook checker deploy in inttest#1310
apedriza merged 1 commit intok0sproject:mainfrom
apedriza:remove-webhook-checker-inttest

Conversation

@apedriza
Copy link
Contributor

@apedriza apedriza commented Dec 3, 2025

currently it floods the controller with errors like:

2025-12-03T16:08:52Z	ERROR	admission	unable to process a request with unknown content type	{"webhookGroup": "k0smotron.io", "webhookKind": "Cluster", "error": "contentType=, expected application/json"}
sigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Webhook).ServeHTTP
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.4/pkg/webhook/admission/http.go:95
sigs.k8s.io/controller-runtime/pkg/webhook/internal/metrics.InstrumentedHook.InstrumentHandlerInFlight.func1
	/go/pkg/mod/github.com/prometheus/client_golang@v1.22.0/prometheus/promhttp/instrument_server.go:60
net/http.HandlerFunc.ServeHTTP
	/usr/local/go/src/net/http/server.go:2220
github.com/prometheus/client_golang/prometheus/promhttp.InstrumentHandlerCounter.func1
	/go/pkg/mod/github.com/prometheus/client_golang@v1.22.0/prometheus/promhttp/instrument_server.go:147
net/http.HandlerFunc.ServeHTTP
	/usr/local/go/src/net/http/server.go:2220
github.com/prometheus/client_golang/prometheus/promhttp.InstrumentHandlerDuration.func2
	/go/pkg/mod/github.com/prometheus/client_golang@v1.22.0/prometheus/promhttp/instrument_server.go:109
net/http.HandlerFunc.ServeHTTP
	/usr/local/go/src/net/http/server.go:2220
net/http.(*ServeMux).ServeHTTP
	/usr/local/go/src/net/http/server.go:2747
net/http.serverHandler.ServeHTTP
	/usr/local/go/src/net/http/server.go:3210
net/http.initALPNRequest.ServeHTTP
	/usr/local/go/src/net/http/server.go:3819
net/http.(*http2serverConn).runHandler
	/usr/local/go/src/net/http/h2_bundle.go:6249

We already have webhook readyz checker

Signed-off-by: apedriza <adripedriza@gmail.com>
@apedriza apedriza marked this pull request as ready for review December 3, 2025 16:29
@apedriza apedriza requested a review from a team as a code owner December 3, 2025 16:29
@apedriza apedriza merged commit ee79f00 into k0sproject:main Dec 4, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants