cluster: support setting externalTrafficPolicy for svc#1293
Merged
makhov merged 1 commit intok0sproject:mainfrom Nov 21, 2025
Merged
cluster: support setting externalTrafficPolicy for svc#1293makhov merged 1 commit intok0sproject:mainfrom
makhov merged 1 commit intok0sproject:mainfrom
Conversation
clwluvw
force-pushed
the
externaltrafficpolicy
branch
from
ce173f7 to
50dccea
Compare
Contributor
Author
Contributor
Author
|
@makhov seems to be failing for the same reason again. |
Contributor
Author
|
@makhov still failing :D |
Contributor
|
Please, rebase you branch on top of the latest main. I think it should fix the issue. |
Allow setting externalTrafficPolicy for the api service. useful when using NodePort and LoadBalancer types. Signed-off-by: Seena Fallah <seenafallah@gmail.com>
clwluvw
force-pushed
the
externaltrafficpolicy
branch
from
50dccea to
9fc9028
Compare
Contributor
Author
Thanks @makhov. I guess you need to approve the workflow now. |
Contributor
Author
|
Thanks @makhov, it should be ready for a review now. |
makhov
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow setting externalTrafficPolicy for the api service. useful when using NodePort and LoadBalancer types.