Fix etcd cert secrets owner in remote host cluster mode#1258
Merged
apedriza merged 1 commit intok0sproject:mainfrom Oct 22, 2025
Merged
Fix etcd cert secrets owner in remote host cluster mode#1258apedriza merged 1 commit intok0sproject:mainfrom
apedriza merged 1 commit intok0sproject:mainfrom
Conversation
When K0smotronCluster uses spec.kubeconfigRef, etcd leaf certs (server/peer/apiserver-etcd-client) were generated but not persisted in the hosting cluster due to an incorrect OwnerReference. Use the external owner when present (same as the control-plane certs path) to ensure secrets are created/retained and etcd pods can start. Signed-off-by: kahirokunn <okinakahiro@gmail.com>
kahirokunn
changed the title
apedriza
reviewed
Oct 22, 2025
Contributor
apedriza
left a comment
apedriza
left a comment
There was a problem hiding this comment.
Changes look good, but wondering if we should add some checks in the remote HCP e2e checking the proper garbage collection of the cluster resources. WDYT?
Contributor
Author
|
That could be a good addition from a different perspective than the bug fix currently being worked on. |
apedriza
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1259
Problem
ensureEtcdCertificatessaved*-etcd-server,*-etcd-peer, and*-apiserver-etcd-clientSecrets with an ownerReference pointing tok0smotron.io/Cluster.Result
The following Secrets are now correctly created and persist in the hosting cluster:
<cluster>-etcd-server<cluster>-etcd-peer<cluster>-apiserver-etcd-clientVerified with:
kubectl -n mgmt get secretshowing the three Secrets presentpod is running on external cluster
Cluster status progressing to Provisioned with ControlPlaneReady = True
cluster works good 👍
