Skip to content

FIFO Queue/Topic Support#1658

Open
nohagan-gs wants to merge 3 commits intojusteattakeaway:mainfrom
nohagan-gs:feature/fifo_support
Open

FIFO Queue/Topic Support#1658
nohagan-gs wants to merge 3 commits intojusteattakeaway:mainfrom
nohagan-gs:feature/fifo_support

Conversation

@nohagan-gs
Copy link
Copy Markdown

This PR makes the following changes:

  • Supports the use of MessageGroupId & MessageDeduplicationId on message publishing (via PublishMetadata)
  • Supports the use of FIFO Topics & Queues
    • Support added to the non-addressed subscription/publication builders (WithFifo)
  • Additional Integration tests for FIFO Topics/Queues

Per discussion in #911 there was openness to FIFO support being contributed

Notes/Questions :

  • When using WithFifo there is an expectation on the configuration to use the ".fifo" suffix on Queue/Topic names - do we want to force the client knowledge of this, or hide it away and auto-add it?
    • Easy enough to do on the Queue/Topic creation, slightly more complexity to propagate it through to the queue -> handler mappings
  • Does not support Content-based deduplication at this time, only based on MessageDeduplicationId
  • Relies on the SNS/SQS Validation that publishing to a FIFO resource requires the MessageGroupId, better to validate pre-publish?
  • The method of specifying the MessageGroupId/MessageDeduplicationId on the PublishBatchMetadata feels clunky, better alternatives?

@nohagan-gs nohagan-gs requested a review from a team as a code owner March 10, 2025 14:42
@nohagan-gs nohagan-gs changed the title Feature/fifo support FIFO Queue/Topic Support Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant