Skip to content
This repository was archived by the owner on Jul 9, 2023. It is now read-only.

Fix for #769: Wildcard bug on second-level domain #920

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

fahlisaputra
Copy link
Contributor

When openning second-level domain like ".ac.id, .co.id, .vn.ua, etc" it will show message "Couldn't authenticate host".
Issue #769

Doneness:

  • Build is okay - I made sure that this change is building successfully.
  • No Bugs - I made sure that this change is working properly as expected. It doesn't have any bugs that you are aware of.
  • Branching - If this is not a hotfix, I am making this request against the develop branch

When openning second-level domain like ".ac.id, .co.id, .vn.ua, etc" it will show message "Couldn't authenticate host".
@andrewfblake
Copy link

ah amazing, we're getting the same issue here with the wildcard certificate not authenticing - looking forward to this ticket being merged in! thank you!

@justcoding121
Copy link
Owner

@honfika Do you agree with this change?

@justcoding121 justcoding121 merged commit 2f8286b into justcoding121:develop Jul 13, 2022
@justcoding121
Copy link
Owner

I modified the logic a little bit.

@justcoding121
Copy link
Owner

justcoding121 commented Jul 13, 2022

I don’t think there is a perfect solution to this. We can add an proxy flag option to disable wild card Certificates altogether in future.

@andrewfblake
Copy link

Good morning, Sensational, thank you! I forked and added the original fix into a local build yesterday to do a little testing and it was working great. Agree with your change too. Yeah, watching the logs, there were still some other resources from the site (like third party adverts, and some google domains etc) that were failing with a 'couldn't authenticate host' but as you say, not sure there is a perfect solution to this and the flag seems like a good feature in the future. Thanks again, really appreciate your help and amazing project.

@fahlisaputra fahlisaputra deleted the patch-1 branch July 14, 2022 11:25
@fahlisaputra
Copy link
Contributor Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants