Skip to content

Unpin sphinx - #85

Merged
martinRenou merged 3 commits into
jupyterlite:mainfrom
lesteve:unpin-sphinx
Feb 3, 2023
Merged

Unpin sphinx#85
martinRenou merged 3 commits into
jupyterlite:mainfrom
lesteve:unpin-sphinx

Conversation

@lesteve

@lesteve lesteve commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

fix #83
close #84

@lesteve

lesteve commented Feb 3, 2023

Copy link
Copy Markdown
Contributor Author

Trying to work-around the conda conflict issue in the CI which is likely related to conda-incubator/setup-miniconda#274

I took inspiration from https://github.com/robotology/ycm/pull/426/files.



class _LiteDirective(SphinxDirective):

@lesteve lesteve Feb 3, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow latest black says there should be no newline here. This was the reason this CI build failed

@martinRenou martinRenou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martinRenou
martinRenou merged commit 29a65cc into jupyterlite:main Feb 3, 2023
@lesteve
lesteve deleted the unpin-sphinx branch February 3, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

release the pin on Sphinx version ?

2 participants