Run jupyter lite with subprocess.run to not suppress stdout

[jasongrout]

check_output redirects stdout, so we don't see it when we do sphinx-build. We instead switch to using subprocess.run so that we can see the stdout output.

Suppressing stdout was causing errors in jupyter lite to not be displayed, which was very confusing.

A separate issue is that jupyter lite is not returning a nonzero exit code when there is an error. But that is a problem to solve in jupyter lite. Once it is solved, having the check=True means that the sphinx build will also raise an error.

[jasongrout]

With this, I bet we'll start seeing the errors in building the current jupyterlite-sphinx docs.

[jasongrout]

With this, I bet we'll start seeing the errors in building the current jupyterlite-sphinx docs.

Yep, now we see the error at the bottom of https://readthedocs.org/api/v2/build/17204236.txt

Since jupyter lite still returned a zero error code indicating success, though, the docs build did not fail.

[martinRenou]

This is great thanks! It's been super annoying to debug jupyterlite-sphinx builds without this. Let's see if #56 fixes the lite build.

It looks like there is a black check failure on the Python code

[martinRenou]

Can you please rebase your PR? We should now not see error logs with #56 in

[jasongrout]

Can you please rebase your PR? We should now not see error logs with #56 in

Done!

[jasongrout]

New error:

piplite:patch
.  post_build:contents:contents:.
.  post_build:federated_extensions:patch
.  post_build:federated_extensions:copy:theme:@telamonian/theme-darcula
.  post_build:federated_extensions:copy:theme:@timkpaine/jupyterlab_miami_nights
.  post_build:mimetypes:patch
.  post_build:piplite:meta:Jinja2-3.0.3-py3-none-any.whl.meta.json
TaskError - taskid:post_build:piplite:meta:Jinja2-3.0.3-py3-none-any.whl.meta.json
PythonAction Error
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/jupyterlite-sphinx/envs/55/lib/python3.7/site-packages/doit/action.py", line 437, in execute
    returned_value = self.py_callable(*self.args, **kwargs)
  File "/home/docs/checkouts/readthedocs.org/user_builds/jupyterlite-sphinx/envs/55/lib/python3.7/site-packages/jupyterlite/addons/piplite.py", line 254, in index_wheel
    name, version, release = get_wheel_fileinfo(whl_path)
  File "/home/docs/checkouts/readthedocs.org/user_builds/jupyterlite-sphinx/envs/55/lib/python3.7/site-packages/jupyterlite/addons/piplite.py", line 269, in get_wheel_fileinfo
    import pkginfo
ModuleNotFoundError: No module named 'pkginfo'
[LiteBuildApp] Exiting application: jupyter

[martinRenou]

Yes, this might be due to the new jupyterlite release that just came out. I'll have a look.

[jtpio]

Maybe installing jupyterlite[piplite] or jupyterlite[all] here will help:

jupyterlite-sphinx/setup.py

Line 12 in e8a21e9

'jupyterlite',

Since pkginfo is defined here as a dependency:

https://github.com/jupyterlite/jupyterlite/blob/d6b790aaef7d585db968a354a66ff129b0f8c350/py/jupyterlite/pyproject.toml#L75

[jasongrout]

Yay, tests pass and docs look great!

Back to adding this to ipywidgets, once this is released...

[martinRenou]

Great thanks Jason!

[martinRenou]

Thanks!

[martinRenou]

@jasongrout 0.4.8 is released :)