Skip to content

Allow whitespace in filenames - #52

Merged
martinRenou merged 1 commit into
jupyterlite:mainfrom
jasongrout:spaces
Jun 17, 2022
Merged

Allow whitespace in filenames#52
martinRenou merged 1 commit into
jupyterlite:mainfrom
jasongrout:spaces

Conversation

@jasongrout

Copy link
Copy Markdown
Collaborator

Without this, a space in a filename makes it into two separate arguments.

This aligns with the literalinclude directive, which also takes filenames:

https://github.com/sphinx-doc/sphinx/blob/7bdc11e87c7d86dcc2a087eccb7a7c129a473415/sphinx/directives/code.py#L374

Without this, a space in a filename makes it into two separate arguments.

This aligns with the literalinclude directive, which also takes filenames:

https://github.com/sphinx-doc/sphinx/blob/7bdc11e87c7d86dcc2a087eccb7a7c129a473415/sphinx/directives/code.py#L374

@martinRenou martinRenou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou
martinRenou merged commit 2501e5b into jupyterlite:main Jun 17, 2022
@jtpio jtpio added the bug Something isn't working label Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants