allow configuring the path of the contents directory - #346
Conversation
This will make sure that timing problems will never arise, and if the contents are at `_build/contents` (or rather, `_build/jupyterlite-contents`) cleaning up after the end of the process is not really required.
for more information, see https://pre-commit.ci
|
reading the configuration docs, what |
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Hi @keewis, sorry about the delay here; it's been conference season for me recently. And I've never gotten around to playing with your xarray PR (as unfortunate as that is, from my end, apologies) :D
My memory also eludes me, but if I remember correctly, the intermediary folder where the notebooks are stored was named contents – which should be something like jupyterlite_contents indeed.
clean up before the next run instead of after the current run
This makes sense to me. We could also escape a bit of this mess and make the intermediary folder a temporary directory per build...
|
no worries, I've found a way to work around any delays: upload a conda package to a custom channel on prefix.dev, then use that until the PR has been resolved.
it was
potentially, but I think it is nice to be able to check the generated notebooks in case anything went wrong. Another option would be to put it by default into |
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Thank you! Yes, let's not touch that any further; I agree with your reasoning to be able to check the notebooks.
I had no clue about uploading conda packages to prefix.dev channels. Looks like this is so much more easier now. Thanks for sharing that tip :)
This is the one remaining issue I have before being able to merge the PR that adds
try_examplesto thexarraydocs.Basically, I would run sphinx once and then retry again after making changes, and if the first run exited with a non-zero exit code the second run would try to execute all the notebooks in the
_contentsdirectory. However, if I were to add_contentstoexclude_patternsjupyterlitewouldn't be able to find the notebooks in_contents.As far as I can tell, changing the path from
_contentsto_build/contents(or_build/jupyterlite-contents) would always succeed, and wouldn't get confused byexclude_patterns. So what I did was:cc @agriyakhetarpal