Minor refactor + typing info - #155
Conversation
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Hi, @Carreau! I'm just helping @steppi a bit with code review on some of the pending PRs and I had a look at the changes here, and they look good on my end. Question: does adding from __future__ import annotations to the top of the file make sense too (and maybe with an accompanied isort rule as well after #156), considering it will be mandated with future Python versions someday? I don't think we're using anything complicated here that will break later.
|
Thanks for the review. I tend to avoid unnecessary More particularly, As for isort, no objections, but I thought the precommit would take care of it ? If not we can just add it. |
|
Thanks for the info, TIL that future-annotations can get us invalid types on earlier Python versions like that. I guess we would have to enable the |
This adds mypy configuration to ignore voici (untyped), and slightly refactor to pass some kwargs explicitely. It also pleases mypy.
steppi
left a comment
There was a problem hiding this comment.
Looks good. Sorry for forgetting about this.
|
No problem, thanks for the review and merge. |
This adds mypy configuration to ignore voici (untyped), and slightly refactor to pass some kwargs explicitely.
It also pleases mypy.