Skip to content

Run pre-commit on all files in this repository. - #145

Merged
Carreau merged 1 commit into
jupyterlite:mainfrom
Carreau:pre-commit
Mar 6, 2024
Merged

Run pre-commit on all files in this repository.#145
Carreau merged 1 commit into
jupyterlite:mainfrom
Carreau:pre-commit

Conversation

@Carreau

@Carreau Carreau commented Mar 6, 2024

Copy link
Copy Markdown
Collaborator

This should only reformat JS and css files.

I've requested precommit-ci to be insalled on the JupyterLIght org, but do not have enough permission to allow it.

One it is done and configured, it will automatically update PRs by autoformatting, so a first pass to autoformat everything is good to not have noise in later PRs.

This should only reformat JS and css files.

I've requested precommit-ci to be insalled on the JupyterLIght org, but
do not have enough permission to allow it.

One it is done and configured, it will automatically update PRs by
autoformatting, so a first pass to autoformat everything is good to not
have noise in later PRs.
@jtpio

jtpio commented Mar 6, 2024

Copy link
Copy Markdown
Member

I've requested precommit-ci to be insalled on the JupyterLIght org, but do not have enough permission to allow it.

Should be good now:

image

@Carreau

Carreau commented Mar 6, 2024

Copy link
Copy Markdown
Collaborator Author

I'm going to merge and rebase my other PR to see if pre-commit triggers.

@Carreau
Carreau merged commit 518686f into jupyterlite:main Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants