Use pre-commit.ci to run pre-commit tests - #62
Merged
consideRatio merged 2 commits intoAug 29, 2021
Conversation
consideRatio
force-pushed
the
pr/pre-commit-switchup
branch
from
August 28, 2021 18:40
d462fec to
cadd4e3
Compare
Merged
consideRatio
force-pushed
the
pr/pre-commit-switchup
branch
from
August 29, 2021 15:46
cadd4e3 to
fcb4996
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've started using pre-commit.ci to run pre-commit tests in jupyterhub/jupyterhub and jupyterhub/zero-to-jupyterhub-k8s - it has been great! Doing so helps us get automatic updates of things in
.pre-commit-config.yaml, automatic patches to PRs applied, and the actual execution of pre-commit tests.I was motivated for this transition initially by not having to split up the test.yaml workflow in two files in order to not trigger all tests no matter if it was only a docs change, but as pre-commit should also trigger on docs change - there was a need to extract pre-commit from the test.yaml workflow file.