Add example LTI 1.1 configuration and readme - #54
Merged
Conversation
Signed-off-by: jgwerner <werner.greg@gmail.com>
consideRatio
approved these changes
Aug 11, 2021
consideRatio
left a comment
consideRatio
left a comment
Member
There was a problem hiding this comment.
This LGTM overall, left a comment to summarize what the example was about, but other than that +1 for merge!
Member
Collaborator
Author
|
@consideRatio good point - I'll update the PRs description to not close the issue automatically. |
Collaborator
Author
|
@consideRatio I opened #56 to help fix some testing issues with the file provided in the examples folder. If possible, we should merge |
consideRatio
approved these changes
Aug 12, 2021
Collaborator
Author
|
@consideRatio rebase was completed and tests are passing now. Let me know if you would like me to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
virtualenv#53