Skip to content

README: updated k8s example - #52

Merged
yuvipanda merged 5 commits into
jupyterhub:masterfrom
BenGig:master
Aug 1, 2021
Merged

README: updated k8s example#52
yuvipanda merged 5 commits into
jupyterhub:masterfrom
BenGig:master

Conversation

@BenGig

@BenGig BenGig commented Jul 27, 2021

Copy link
Copy Markdown
Contributor

Changed the configuration example, replaced the outdated auth: type: "LTI" configuration syntax.

I also included the extraConfig mentioned in #50.

@welcome

welcome Bot commented Jul 27, 2021

Copy link
Copy Markdown

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@yuvipanda
yuvipanda requested a review from consideRatio July 27, 2021 08:50
Comment thread README.md Outdated
@jgwerner
jgwerner self-requested a review July 30, 2021 21:09

@jgwerner jgwerner left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenGig thanks for clarifying the documentation, LGTM!

Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
@yuvipanda
yuvipanda merged commit 6d01274 into jupyterhub:master Aug 1, 2021
@welcome

welcome Bot commented Aug 1, 2021

Copy link
Copy Markdown

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@yuvipanda

Copy link
Copy Markdown
Collaborator

Thanks a lot for this update, @BenGig! And thanks for the review, @consideRatio and @jgwerner!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants