Add username_key as an LTI 1.1 Authenticator configurable - #48
Conversation
Signed-off-by: Greg Werner <werner.greg@gmail.com>
Signed-off-by: Greg Werner <werner.greg@gmail.com>
Signed-off-by: Greg Werner <werner.greg@gmail.com>
yuvipanda
left a comment
There was a problem hiding this comment.
Awesome! Couple minor things, happy to merge afterwards
|
What do you think of making a release after this gets merged? |
|
@yuvipanda creating a new release sounds good to me! I'll update this PR based on your comments, thanks for the review. |
consideRatio
left a comment
There was a problem hiding this comment.
@jgwerner wow amazing work!!! I appreciate how thorough you are!
Excellent documentation, excellent testing! ❤️ 🎉
Assuming @yuvipanda comments are addressed, this LGTM so I'll press approve at this point!
Signed-off-by: Greg Werner <werner.greg@gmail.com>
|
@yuvipanda I updated the PR with the following logic:
There were also some duplicate validator tests in the authentication tests file so removed them. Perhaps we should have refactored tests in another PR, but wanted to make sure the flow above had passing tests without duplicates. |
Signed-off-by: Greg Werner <werner.greg@gmail.com>
|
@jgwerner thank you for your patience :) This lgtm for the most part - I left some documentation change suggestions, what do you think? Happy to merge this after. |
|
@yuvipanda I update the PR based on your suggestions, thanks for the documentation tips 👍 |
Signed-off-by: Greg Werner <werner.greg@gmail.com>
|
Thank you, @jgwerner! |
LTI11Authenticator.username_keyto set the username returned by the authenticator to something other thancustom_canvas_user_idoruser_idif specifiedLTI11AuthenticateHandlerclassContinuation of #14
Closes #30
cc/ @BenGig