Skip to content

Add common utility functions for LTI 1.1 and LTI 1.3 - #43

Merged
yuvipanda merged 5 commits into
jupyterhub:masterfrom
jgwerner:refactor/update-utils
Apr 26, 2021
Merged

Add common utility functions for LTI 1.1 and LTI 1.3#43
yuvipanda merged 5 commits into
jupyterhub:masterfrom
jgwerner:refactor/update-utils

Conversation

@jgwerner

Copy link
Copy Markdown
Collaborator
  • Adds common functions to normalize strings, fetch usernames, etc to keep things DRY
  • Updates utils tests

Closes #42

Signed-off-by: Greg Werner <werner.greg@gmail.com>
Signed-off-by: Greg Werner <werner.greg@gmail.com>
Signed-off-by: Greg Werner <werner.greg@gmail.com>
@jgwerner

jgwerner commented Apr 15, 2021

Copy link
Copy Markdown
Collaborator Author

@yuvipanda most of your comments from #44 about escapism will be are dealt with here and then we can rebase update the authenticator, tests, and rebase #44 before merging.

Signed-off-by: Greg Werner <werner.greg@gmail.com>
Signed-off-by: Greg Werner <werner.greg@gmail.com>
@yuvipanda

Copy link
Copy Markdown
Collaborator

Thanks, @jgwerner!

@yuvipanda
yuvipanda merged commit 012fb8e into jupyterhub:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update package with common utility functions

3 participants