Add pre-commit and formatting tools - #40
Merged
Merged
Conversation
Signed-off-by: Greg Werner <werner.greg@gmail.com>
Collaborator
Author
|
@yuvipanda as soon as you merge this PR I'll send one to refactor the existing LTI 1.1 setup based on #2 and then will add a separate one for LTI 1.3. |
Merged
Collaborator
Author
|
@yuvipanda I submitted #41 as a preview to this merge. I'll rebase once it's time to merge. |
yuvipanda
requested changes
Mar 21, 2021
yuvipanda
left a comment
yuvipanda
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for doing this! One minor comment, otherwise happy to merge :)
Signed-off-by: Greg Werner <werner.greg@gmail.com>
Collaborator
Author
|
@yuvipanda the comment regarding semantic versioning has been removed. |
|
Congrats on your first merged pull request in this project! 🎉 |
Collaborator
|
w00t, thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #38 and #39