Skip to content

maint(lti11): Silence OAuthlib deprication warnings - #129

Merged
consideRatio merged 1 commit into
jupyterhub:mainfrom
martinclaus:silence-oauthlib-deprication-warnings
Feb 24, 2023
Merged

maint(lti11): Silence OAuthlib deprication warnings#129
consideRatio merged 1 commit into
jupyterhub:mainfrom
martinclaus:silence-oauthlib-deprication-warnings

Conversation

@martinclaus

Copy link
Copy Markdown
Collaborator

oauthlib.oauth1.rfc5849.signature.sign_hmac_sha1 has been depricated. This function has been replaced by oauthlib.oauth1.rfc5849.signature.sign_hmac_sha1_with_client, which has slightly different signature.

@consideRatio consideRatio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

@consideRatio
consideRatio merged commit d528114 into jupyterhub:main Feb 24, 2023
@consideRatio

Copy link
Copy Markdown
Member

When we generate changelogs according to RELEASE.md using the CLI tool github-activity, it is great that you have added either maintenance, new, bug like done already for this PR!

If you know something to be breaking, we like to also make sure the PR description includes notes on whats breaking, and that the label breaking is added.

Thank you @martinclaus for your work!!!!

@martinclaus martinclaus changed the title Silence OAuthlib deprication warnings maint(lti11): Silence OAuthlib deprication warnings Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants