docs(lti11): Use consistent module path for LTI11Authenticator - #112
Conversation
|
Hi @BenGig, thanks for the contribution! We had kept the To avoid confusion, perhaps we could update the documentation to reflect both of these options. @consideRatio @yuvipanda do you think? |
|
I think since the new suggestion requires 1.3.0, and 1.3.0 isn't available for example in the JupyterHub Helm chart yet for reasons, I figure we should stick with the old syntax for now and merge this after next release as its probably better that users are explicit with what they intend to use. I'll make this a draft PR for now. Action point
|
|
@consideRatio I guess this can be merged now? |
|
Absolutely, I'm on vacation until tomorrow. Feel free to merge if you consider this docs-only change is ready! |
I found a small inconsistency in the README. AFAIK the authenticator class in the example at line 106 should be tiauthenticator.LTI11Authenticator, as in the note below the example.