feat(lti13): Make tool name & description configurable - #103
Merged
Conversation
This used to display information about the JupyterHub in the LMS
for more information, see https://pre-commit.ci
consideRatio
reviewed
Jun 3, 2022
| help=""" | ||
| Name of tool provided to the LMS when installed via the config URL. | ||
|
|
||
| This is primarily used for display purposes. |
Member
There was a problem hiding this comment.
As a person inspecting this code without using it, this is a very important point answering a question that I've had :)
consideRatio
reviewed
Jun 3, 2022
| self.log.debug(f"Target link url is: {target_link_url}") | ||
| keys = { | ||
| "title": "JupyterHub", | ||
| "title": self.authenticator.tool_name, |
Member
There was a problem hiding this comment.
Ah, referencing the authenticator instance this is possible via BaseHandler: https://github.com/jupyterhub/jupyterhub/blob/049a59f2ed2d5f4f20efd489df6504f403620e02/jupyterhub/handlers/base.py#L166-L168.
consideRatio
approved these changes
Jun 3, 2022
consideRatio
changed the title
Member
|
Nice thanks @yuvipanda!! |
martinclaus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This used to display information about the JupyterHub
in the LMS