Skip to content

Update Jupytext Notebook url path #6961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Update Jupytext Notebook url path #6961

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59556b6
update Jupytext Notebook url path
RRosio Jul 6, 2023
76ae06c
update widget name check
RRosio Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/docmanager-extension/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ const opener: JupyterFrontEndPlugin<IDocumentWidgetOpener> = {
let route = 'edit';
if (
(widgetName === 'default' && ext === '.ipynb') ||
widgetName === 'Notebook'
widgetName === 'Notebook' ||
widgetName === 'Jupytext Notebook'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe we can check if widgetName contains the string Notebook?

jupytext is a third-party extension and not officially supported, so not sure we should hardcode its special case here.

) {
route = 'notebooks';
}
Expand Down