-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add .mo and .json files for translations #6728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👍 for the suggestion For information, in the language packs repo mentioned, we did version the .mo and .json files up to recently. |
I tried out the translations and from what I could cross-reference with a translator, it looked good! |
@RRosio Sure, Let's get that merged before cutting a new 6.5 |
I have checked Why is the Any Russian, Japan or Chinese language skills around? |
Will this need to be ported to NbClassic? |
I believe for dutch the Unfortunately I personally can't provide much feedback on the different languages included in this PR...
Yes I believe a PR would also need to be submitted to make these files available for nbclassic. |
I'll regenerate the files and open a PR there as well. |
Correction. This is not needed for nbclassic because the build process does it.
There is only one small bug I'm gonna report or fix but the .mo and .json files are already present in the sdist and wheel. |
"Jupyter Notebook について" | ||
], | ||
"unable to contact kernel": [ | ||
"kernel と通信できません" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"kernel と通信できません" | |
"カーネルと通信できません" |
Consistent styling of "kernel" with commands below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the proposal but this file is generated from the nbjs.po
source file so the change should be proposed to that file and nbjs.json can be regenerated then, see
msgstr "kernel と通信できません" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #6744 for a PR to make this modification. Thanks!
|
I!m gonna rebase this one once the #6745 is merged. |
Just merged it! |
666bc25
to
a1453bf
Compare
This PR is now rebased and the files are regenerated based on the latest changes in the mentioned PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ru_RU translation looks good
Thank you @frenzymadness and everyone for participating, looks good to merge now! |
See the discussion in #6717
Shipping just .po files is useless because users would need to generate .mo files from them to make the translation work. Much better would be to update the release process to make this automatic, regenerate .mo and .json files, and remove .po files when building the wheel but because notebook v 7 will use a different system with language packs (where this automation is implemented) it does not really make sense to make this fix more complicated than it is.
I know that the .mo files are binary and therefore not good for being tracked in the git but this seems to be acceptable as a short term solution for notebook 6.
Also, the files were for some reason ignored via .gitignore file but nl translation has them.