Skip to content

Conversation

frenzymadness
Copy link
Contributor

See the discussion in #6717

Shipping just .po files is useless because users would need to generate .mo files from them to make the translation work. Much better would be to update the release process to make this automatic, regenerate .mo and .json files, and remove .po files when building the wheel but because notebook v 7 will use a different system with language packs (where this automation is implemented) it does not really make sense to make this fix more complicated than it is.

I know that the .mo files are binary and therefore not good for being tracked in the git but this seems to be acceptable as a short term solution for notebook 6.

Also, the files were for some reason ignored via .gitignore file but nl translation has them.

@fcollonval
Copy link
Collaborator

👍 for the suggestion

For information, in the language packs repo mentioned, we did version the .mo and .json files up to recently.

@RRosio
Copy link
Collaborator

RRosio commented Feb 20, 2023

I tried out the translations and from what I could cross-reference with a translator, it looked good!
@echarles is this something that could be included in the next release of 6.5?

@echarles
Copy link
Member

echarles commented Feb 20, 2023

@RRosio Sure, Let's get that merged before cutting a new 6.5

@echarles
Copy link
Member

I have checked notebook/i18n/fr_FR/LC_MESSAGES/nbjs.json and it looks good. Well, noyau is the literate translation of kernel and I have always found weird those kind of translation... The sentence Le noyau semble planté is a bit weird also, but just acceptable. The rest looks OK.

Why is the notebook/i18n/nl/LC_MESSAGES/nbjs.json not included in this PR? I could have a look also, my dutch is basic but ok.

Any Russian, Japan or Chinese language skills around?

@echarles echarles added the bug label Feb 20, 2023
@echarles
Copy link
Member

Will this need to be ported to NbClassic?

@RRosio
Copy link
Collaborator

RRosio commented Feb 20, 2023

Why is the notebook/i18n/nl/LC_MESSAGES/nbjs.json not included in this PR? I could have a look also, my dutch is basic but ok.

I believe for dutch the notebook/i18n/nl/LC_MESSAGES/nbjs.json is already present

Unfortunately I personally can't provide much feedback on the different languages included in this PR...

Will this need to be ported to NbClassic?

Yes I believe a PR would also need to be submitted to make these files available for nbclassic.

@frenzymadness
Copy link
Contributor Author

Yes I believe a PR would also need to be submitted to make these files available for nbclassic.

I'll regenerate the files and open a PR there as well.

@frenzymadness
Copy link
Contributor Author

Yes I believe a PR would also need to be submitted to make these files available for nbclassic.

I'll regenerate the files and open a PR there as well.

Correction. This is not needed for nbclassic because the build process does it.

There is only one small bug I'm gonna report or fix but the .mo and .json files are already present in the sdist and wheel.

"Jupyter Notebook について"
],
"unable to contact kernel": [
"kernel と通信できません"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"kernel と通信できません"
"カーネルと通信できません"

Consistent styling of "kernel" with commands below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal but this file is generated from the nbjs.po source file so the change should be proposed to that file and nbjs.json can be regenerated then, see

msgstr "kernel と通信できません"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #6744 for a PR to make this modification. Thanks!

@andrii-i
Copy link
Contributor

andrii-i commented Feb 22, 2023

Any Russian, Japan or Chinese language skills around?

@frenzymadness
Copy link
Contributor Author

Any Russian, Japan or Chinese language skills around?

* Opened [Fix ru_RU translation #6745](https://github.com/jupyter/notebook/pull/6745). It fixes mistakes and makes ru_RU translation more consistent

I!m gonna rebase this one once the #6745 is merged.

@RRosio
Copy link
Collaborator

RRosio commented Feb 23, 2023

I!m gonna rebase this one once the #6745 is merged.

Just merged it!

@frenzymadness
Copy link
Contributor Author

This PR is now rebased and the files are regenerated based on the latest changes in the mentioned PRs.

Copy link
Contributor

@andrii-i andrii-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ru_RU translation looks good

@RRosio
Copy link
Collaborator

RRosio commented Feb 23, 2023

Thank you @frenzymadness and everyone for participating, looks good to merge now!

@RRosio RRosio merged commit 7939fc5 into jupyter:6.5.x Feb 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants