Skip to content

Add more lint checks #6706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Add more lint checks #6706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e21ea74
add more lint checks
blink1073 Jan 29, 2023
6d35367
fix lint
blink1073 Jan 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ repos:
- id: black

- repo: https://github.com/charliermarsh/ruff-pre-commit
rev: v0.0.207
rev: v0.0.237
hooks:
- id: ruff
args: ["--fix"]
Expand Down
14 changes: 8 additions & 6 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,18 +146,18 @@ dependencies = [
"black[jupyter]==22.10.0",
"mdformat>0.7",
"mdformat-gfm>=0.3.5",
"ruff==0.0.189"
"ruff==0.0.237"
]
detached = true
[tool.hatch.envs.lint.scripts]
style = [
"ruff {args:notebook tests ui-tests}",
"ruff {args:.}",
"black --check --diff {args:.}",
"mdformat --check {args:CHANGELOG.md}"
]
fmt = [
"black {args:.}",
"ruff --fix {args:notebook}",
"ruff --fix {args:.}",
"mdformat {args:CHANGELOG.md}"
]

Expand Down Expand Up @@ -252,8 +252,9 @@ skip-string-normalization = true
target-version = "py37"
line-length = 100
select = [
"A", "B", "C", "E", "F", "FBT", "I", "N", "Q", "RUF", "S", "T",
"UP", "W", "YTT",
"A", "B", "C", "DTZ", "E", "EM", "F", "FBT", "I", "ICN", "ISC", "N",
"PLC", "PLE", "PLR", "PLW", "Q", "RUF", "S", "SIM", "T", "TID", "UP",
"W", "YTT",
]
ignore = [
# Q000 Single quotes found but double quotes preferred
Expand All @@ -267,7 +268,8 @@ ignore = [
[tool.ruff.per-file-ignores]
# S101 Use of `assert` detected
# F841 Local variable `foo` is assigned to but never used
"tests/*" = ["S101", "F841"]
# PLR2004 Magic value used in comparison
"tests/*" = ["S101", "F841", "PLR2004"]

[tool.interrogate]
ignore-init-module=true
Expand Down