do not apply asyncio patch for tornado >=6.1#5907
Merged
minrk merged 1 commit intojupyter:masterfrom Dec 14, 2020
Merged
Conversation
Closed
Contributor
Author
Contributor
Author
|
Also, incidentally: can you think of any other places we had to do this stuff? I think i hit most of them... |
Member
I did a search and it looks like:
|
Member
I'm okay! Super busy and spread a little thin, but trying to keep up. How are you? :) |
Contributor
Author
|
Same... it'll be great when all the stuff that's in the air lands, but it does seem like a lot right now! |
Member
|
Looking back at tornado docs, I think we should still be using the selector loop all the time. Performance will be better, as ~everything we do is built add/remove_reader, which are slower when proactor is used do to the extra thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tornado 6.1 now no longer requires the asyncio patch on windows for python >=3.8. 🎉
On jupyter-server/jupyter_server#339, we went with a hard cut to require 6.1, and remove the patch, but this PR applies the lighter touch from ipython/ipykernel#564 of just not applying the patch.
Fixing this is good, as the error manifests itself as unkillable python hang on windows, timing out CI.