Support psutil for finding network addresses #1033
Merged
+38
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cben
added a commit
to cben/jupyter_client
that referenced
this pull request
Jan 7, 2025
Followup to jupyter#1033, apparently docstring got copy-pasted from _load_ips_netifaces
minrk
pushed a commit
that referenced
this pull request
Jan 8, 2025
Followup to #1033, apparently docstring got copy-pasted from _load_ips_netifaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
netifacespackage has been archived by upstream, and pre-compiled wheels are not available for Python >= 3.10. An alternative is the maintainedpsutilpackage, and this PR tries to determine network addresses (inlocalinterfaces.py) using this package before falling back tonetifacesand the other existing methods.