Skip to content

basic approach for separate pytest plugin package#338

Closed
bollwyvl wants to merge 9 commits intojupyter-server:masterfrom
bollwyvl:gh-337-separate-package
Closed

basic approach for separate pytest plugin package#338
bollwyvl wants to merge 9 commits intojupyter-server:masterfrom
bollwyvl:gh-337-separate-package

Conversation

@bollwyvl
Copy link
Copy Markdown
Contributor

The simplest packaging I could do. Probably needs something to keep the parent/plugin versions in sync, and a release approach.

@kevin-bates
Copy link
Copy Markdown
Member

Thank you Nick! Given we're packaging the fixtures in https://github.com/jupyter-server/pytest-jupyter, I believe some of these changes are probably warranted there (e.g., use of options.entry_points). It would be great if you could take a look at the packaging aspects on that repo.

Others of these commits have been addressed in #335.

We were going to remove the entry point in a follow-on PR, post #335, which is #339, so I'm thinking the spirit of this PR is really what has happened in the pytest-jupyter repo and we should apply any additional necessities there.

Are you good with closing this PR, while focusing on #335 and #339 here, with some additional focus (relative to packaging, etc.) in pytest-juptyer?

@bollwyvl
Copy link
Copy Markdown
Contributor Author

bollwyvl commented Nov 13, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pytest_tornasync becomes hard dependency if pytest is installed

2 participants