basic approach for separate pytest plugin package#338
Closed
bollwyvl wants to merge 9 commits intojupyter-server:masterfrom
Closed
basic approach for separate pytest plugin package#338bollwyvl wants to merge 9 commits intojupyter-server:masterfrom
bollwyvl wants to merge 9 commits intojupyter-server:masterfrom
Conversation
Member
|
Thank you Nick! Given we're packaging the fixtures in https://github.com/jupyter-server/pytest-jupyter, I believe some of these changes are probably warranted there (e.g., use of Others of these commits have been addressed in #335. We were going to remove the entry point in a follow-on PR, post #335, which is #339, so I'm thinking the spirit of this PR is really what has happened in the pytest-jupyter repo and we should apply any additional necessities there. Are you good with closing this PR, while focusing on #335 and #339 here, with some additional focus (relative to packaging, etc.) in pytest-juptyer? |
Contributor
Author
|
Thanks for super quick review!
Will investigate those links this weekend, hopefully!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simplest packaging I could do. Probably needs something to keep the parent/plugin versions in sync, and a release approach.