Skip to content

Fix TODOs New API#182

Merged
joaquimg merged 5 commits intojg/newdofrom
ar/newdo
Aug 18, 2025
Merged

Fix TODOs New API#182
joaquimg merged 5 commits intojg/newdofrom
ar/newdo

Conversation

@andrewrosemberg
Copy link
Copy Markdown
Collaborator

No description provided.

@andrewrosemberg andrewrosemberg self-assigned this Aug 16, 2025
@andrewrosemberg
Copy link
Copy Markdown
Collaborator Author

andrewrosemberg commented Aug 17, 2025

Tests indicate 2 issues remaining:

  • The getter for ConstraintPrimal need for implementing correctly:
function MOI.get(
    model::Optimizer,
    attr::MOI.ConstraintPrimal,
    c::MOI.ConstraintIndex,
)
    # optimizer_ci = get(model.constraint_outer_to_inner, c, c)
    # value = MOI.get(model.optimizer, attr, optimizer_ci)
    # inner_ci = model.constraint_outer_to_inner[c]
    # if haskey(model.quadratic_constraint_cache_set, inner_ci)
    #     set = model.quadratic_constraint_cache_set[inner_ci]
    # # TODO : this method will not work well due to the usage of
    # of normalize and add. We need to add more info to cache
    # end
    return MOI.Utilities.get_fallback(model, attr, c)
end
  • and some default linear tests from MOI are giving infeasible when they should be feasible (Also happening in Master).

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (jg/newdo@2c84949). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/MOI_wrapper.jl 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             jg/newdo     #182   +/-   ##
===========================================
  Coverage            ?   87.65%           
===========================================
  Files               ?        5           
  Lines               ?     1474           
  Branches            ?        0           
===========================================
  Hits                ?     1292           
  Misses              ?      182           
  Partials            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joaquimg joaquimg merged commit b3191fe into jg/newdo Aug 18, 2025
6 checks passed
@joaquimg joaquimg deleted the ar/newdo branch August 18, 2025 04:02
joaquimg added a commit that referenced this pull request Aug 19, 2025
* temp

* fix and format

* remove func

* Adds support for VectorQuadraticFunction (#179)

* add ParametricVectorQuadraticFunction

* use at_variable and remove unecessary calls

* start addressing variable coefficients

* update tests

* fix bugs

* fix bug

* update add constraint

* update test

* update jump test

* fix test

* rm update

* update add_constraint

* attemp replace

* update functions

* update

* update

* working first set

* update tol

* update tol

* finish

* change tests names

* Apply suggestions from code review

---------

Co-authored-by: Joaquim <joaquimdgarcia@gmail.com>

* format

* fix NLP block

* continue fix NLP block

* Fix TODOs New API (#182)

* fix VariablePrimalStart

* add get VariablePrimalStart

* fix "is_valid"

* fix ambiguity

* format

---------

Co-authored-by: joaquimg <joaquimdgarcia@gmail.com>

* Ar/newdo (#183)

* fix VariablePrimalStart

* add get VariablePrimalStart

* fix "is_valid"

* fix ambiguity

* format

* add more vector tests

---------

Co-authored-by: Andrew <arosemberg3@gatech.edu>

* add tests and vec fucntionfix

* format

* Fix key vector quadratic and add tests (#184)

* fix key vector quadratic

* add new tests and fix affine cache

* format

* test constraint name set and get

* add no parameter problem

* fix test name

* fix comment

* force has_parameter and !_is_vector_affine

* update coverage

* remove useless function

* update tests coverage

* format and rm useless functions

* improve tests to force coverage improvement

* fix typo

* Improve coverage (#187)

* update tests and coverage

* update tests

* update tests

* add copy to test

* fix typo

* format

* fix typo

* Improve coverage 2.0 (#188)

* improve coverage 2.0

* format

* fix typo

* bump version

---------

Co-authored-by: Andrew Rosemberg <andrewrosemberg@gmail.com>
Co-authored-by: Andrew <arosemberg3@gatech.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants