Remove dual solution warning from optimize!#154
Merged
joaquimg merged 5 commits intojump-dev:masterfrom Jul 2, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #154 +/- ##
=======================================
Coverage 95.14% 95.14%
=======================================
Files 5 5
Lines 1010 1010
=======================================
Hits 961 961
Misses 49 49 ☔ View full report in Codecov by Sentry. |
blegat
reviewed
Jul 2, 2024
src/MOI_wrapper.jl
Outdated
| c::MOI.ConstraintIndex{MOI.VariableIndex,MOI.Parameter{T}}, | ||
| ) where {T} | ||
| if !model.evaluate_duals | ||
| error() |
Member
There was a problem hiding this comment.
This should be throw(MOI.GetAttributeNotAllowed("..."))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace "Dual solution not available" warning in
MOI.optimize!with an error inMOI.get. Otherwise, a warning is shown even when duals are not requested.