Skip to content

Enable vOptLib tests for KirlikSayin and TambyVanderpooten #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

odow
Copy link
Member

@odow odow commented Jun 16, 2025

No description provided.

MOI.set(model, MOA.Algorithm(), MOA.DominguezRios())
MOI.set(model, MOI.Silent(), true)
# TODO(odow): it doesn't terminate
# vOptLib.run_tests(model)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kofgokhan it looks like there's a bug in DominguezRios. It doesn't terminate on this problem (it gets into an infinite loop):

using Revise
import HiGHS
import MultiObjectiveAlgorithms as MOA
import MultiObjectiveAlgorithms: MOI

include("test/vOptLib.jl")

model = MOA.Optimizer(HiGHS.Optimizer)
MOI.set(model, MOA.Algorithm(), MOA.DominguezRios())
MOI.set(model, MOI.Silent(), true)
MOI.set(model, MOI.TimeLimitSec(), 60.0)
vOptLib.test_vOptLib_2KP50_11(model)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not replicate this on my machine. It returns 43 points. Used both HiGHS and CPLEX and I have not changed the tolerances. Did something change?

> model = MOA.Optimizer(HiGHS.Optimizer)
> MOI.get(model, MOI.RawOptimizerAttribute("primal_feasibility_tolerance"))
1.0e-7

> model = MOA.Optimizer(CPLEX.Optimizer)
> MOI.get(model, MOI.RawOptimizerAttribute("CPX_PARAM_EPRHS"))
1.0e-6

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My conclusion in #121 is that it's a presolve issue in HiGHS. If you can't replicate, then it probably means that it's machine dependent too :(

Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.85%. Comparing base (10120b5) to head (0204c5e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files           9        9           
  Lines         959      959           
=======================================
  Hits          948      948           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odow odow merged commit 08f7799 into master Jun 16, 2025
7 checks passed
@odow odow deleted the od/more-ukp-tests branch June 16, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants