Improve title in void-dom-elements-no-children.md #1121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the name of the rule in parentheses at the end of Markdown title like in other documentation files.
|
Replaces #1078 |
yannickcr
requested changes
Mar 21, 2017
| @@ -1,4 +1,4 @@ | |||
| # Prevent void DOM elements (e.g. `<img />`, `<br />`) from receiving children | |||
| # Prevent void DOM elements (e.g. `<img />`, `<br />`) from receiving children (react/void-dom-elements-no-children) | |||
There was a problem hiding this comment.
We did not put the react/ prefix in the other titles, I think it's not necessary to put it here either
There was a problem hiding this comment.
This was my request, per #1078 (comment)
There was a problem hiding this comment.
Ho, did now saw your comment and #1071. Ok then :)
yannickcr
approved these changes
Mar 22, 2017
ljharb
approved these changes
Mar 22, 2017
1 task
This was referenced Sep 22, 2018
This was referenced Oct 25, 2018
1 task
1 task
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the name of the rule in parentheses at the end of Markdown title like in other documentation files.