-
-
Notifications
You must be signed in to change notification settings - Fork 375
fix: sidebar overflow on mobile #1949 #1950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sidebar overflow on mobile #1949 #1950
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1950 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 633 633
Branches 196 196
=========================================
Hits 633 633 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @Utkarsh-123github please review it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DivyanshuVortex , just a small suggestion,
For static Tailwind class names, there’s no need to wrap them in {}.
We usually use braces only when there’s dynamic logic involved, for example:
className={`hidden lg:block px-4 ${
isDark ? 'text-slate-300' : 'text-slate-600'
}`}
Please fix this, and then your PR will be ready for merge. Thank you!
|
Sir @Utkarsh-123github , I make all the required changes in the Tailwind classes pls have a look . |
Utkarsh-123github
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM🚀
What kind of change does this PR introduce?
Bugfix + Minor UI improvement
Issue Number:
Screenshots/videos:
Add screenshots or screen recordings showing the sidebar overflow before/after.
Add before/after for homepage link styling.
If relevant, did you update the documentation?
Not required.
Summary
This PR includes two related UI improvements:
1. Fix: Mobile sidebar overflow (Issue #1949)
On screens below 1024px, opening the sidebar caused the page to become wider than the viewport — triggering horizontal scrolling and shifting the layout.
The fix ensures:
overflow-x-hiddenand layout constraints applied2. UI improvement: Simplified homepage email and link styling
The “Email us” link on the homepage previously looked inconsistent with other links and required hover to appear interactive.
Updated styling:
This improves clarity and accessibility without major design changes.
Does this PR introduce a breaking change?
No.
Checklist
Before -

After -

