Skip to content

Conversation

idanidan29
Copy link
Collaborator

@idanidan29 idanidan29 commented Aug 1, 2025

What kind of change does this PR introduce?

Restructure the component for better modularity Split StyledMarkdown.tsx (709 lines) into 4 focused modules:

  1. lib/markdownUtils.ts - Utility functions, regex constants, and helper types
  2. components/TabsGroup.tsx - Standalone tabs component with switching logic
  3. components/TableOfContentMarkdown.tsx - TOC rendering with heading depth controls
  4. components/StyledMarkdownBlock.tsx - Core markdown rendering with all overrides
  5. components/StyledMarkdown.tsx - Main orchestrator (reduced to 71 lines)
  • adapted summary, details and Bigquote for darkmode.
  • adjusted the StyledMarkdown Tabs for mobile

Issue Number:

Screenshots/videos:

Summary

Does this PR introduce a breaking change?

no

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@idanidan29 idanidan29 requested a review from a team as a code owner August 1, 2025 12:33
@github-project-automation github-project-automation bot moved this to Ready to review in PR - Triage Group Aug 1, 2025
@idanidan29 idanidan29 added the GSoC Google Summer of Code related label Aug 1, 2025
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a1ea8aa) to head (b08e096).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1788   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          633       633           
  Branches       196       196           
=========================================
  Hits           633       633           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Aug 1, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview fdf095f

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. Good job with the refactoring Idan. This PR reflects really well the primary goal of the GSoC project.

@benjagm benjagm merged commit e97ceb0 into json-schema-org:main Aug 4, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Ready to review to Done in PR - Triage Group Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Google Summer of Code related
Projects
Status: Done
2 participants