Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

This PR contains automated updates from running npm run update

@github-actions github-actions bot added the automated update PR created by automation label Jul 12, 2024
@jonchurch
Copy link
Member

jonchurch commented Jul 12, 2024

good bot

Had to change base branch, bc we were triggering this manually from the branch we were working off of to fix the action at the time.

@jonchurch jonchurch changed the base branch from update-action-fix to master July 12, 2024 20:22
@wesleytodd
Copy link
Member

Now that it is merged we should re-kick off the action and make sure this PR is clean with just the updates from the mime type changes and not the action changes itself.

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct now!

@wesleytodd wesleytodd merged commit 3efadc2 into master Jul 12, 2024
@davidmarkclements
Copy link

davidmarkclements commented Jul 18, 2024

@wesleytodd @jonchurch I think it's important to note that this should have been a major release, changing mime-types for .js/.mjs from application/javascript to text/javascript is a breaking change (I know it's breaking because we just traced our breakage to this)

@wesleytodd
Copy link
Member

wesleytodd commented Jul 18, 2024

Hey! This package has never treated mime changes in the data as part of the semver contract. We have a discussion here about this topic you can read if you like: jshttp/mime-types#126

Additionally, I will open a PR to this package with a similar readme addition. I totally understand the concern, and I had the same concern, but it was not this PR that broke it it was this one: #262

Which was merged before the new group took over the project, but we all agree that keeping semver with externally sourced data is untennable. Going forward if this is a concern for you this package needs to be pinned in your project (and I will add the docs to make that clear for folks if they were not clear previously).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated update PR created by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants