Skip to content

Fix bindings leak #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

Fix bindings leak #40

merged 1 commit into from
Nov 5, 2024

Conversation

LordOfSpelunky
Copy link
Contributor

@LordOfSpelunky LordOfSpelunky commented Oct 28, 2024 •
edited
Loading

@grilme99
Copy link
Member

grilme99 commented Nov 5, 2024

Thanks for this!

@grilme99 grilme99 merged commit 918a4c1 into jsdotlua:main Nov 5, 2024
1 check failed
@matthargett
Copy link
Collaborator

I love love love that you wrote a test verifying the cleanup behavior!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grilme99 grilme99 grilme99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LordOfSpelunky @grilme99 @matthargett