delete() and "?"

[stevenvachon]

const nativeURL = require("url").URL;
const shimmedURL = require("whatwg-url").URL;

const native = new nativeURL("http://host/?param");
native.searchParams.delete("param");
native.href;
//-> http://host/

const shimmed = new shimmedURL("http://host/?param");
shimmed.searchParams.delete("param");
shimmed.href;
//-> http://host/?

Pretty sure that the native one is correct. @TimothyGu ?

[TimothyGu]

What do browsers do?

[TimothyGu]

I'm reasonably certain that Node.js' behavior is the faulty one here.

Can you file an issue at node instead?

[stevenvachon]

Chrome and Firefox both behave like Node.js

[stevenvachon]

Ok, nodejs/node#14020

[TimothyGu]

Added this case to WPT in web-platform-tests/wpt#6445. Will apply the fix to Node.js after the PR is merged.

[TimothyGu]

This should be reopened now that whatwg/url#336 has been merged.