-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(core): adds angular 20 support #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
dda2999
fix: correct output and input decorators in PreventMultipleClicksDire…
pavankjadda 893e7fa
feat(testing): adds Karma configuration file for testing setup
pavankjadda 12a07a6
feat(tests): add initial test files and configuration for PreventMult…
pavankjadda 226432b
feat: update Angular configuration and add tests for PreventMultipleC…
pavankjadda 16f1d6c
Merge branch 'main' into development
pavankjadda 215d957
feat: update AlertComponent to use Angular signals and improve type s…
pavankjadda 1554343
feat(tests): refactor PreventMultipleClicksDirective tests and update…
pavankjadda 78e1603
feat: refactor NgxSpinnerComponent to use input() for properties and …
pavankjadda 0a62596
feat: update ESLint configuration and README for build command
pavankjadda 8c6edd1
feat: update ESLint configuration for alert-demo component and improv…
pavankjadda 980e9cd
feat: update ESLint configuration
pavankjadda 4cf1493
feat: refactor components for improved readability and consistency
pavankjadda b717d1d
feat: update autocomplete component and mat-snack-bar service for imp…
pavankjadda 1e8a872
feat: enhance ngx-spinner component and add print options for improve…
pavankjadda ad0d42e
feat(core): adds angular 20 support
pavankjadda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| We use latest Angular and TypeScript for our angular development. Always show examples and reference the latest version of Angular and TypeScript in your responses. If in doubt, use docs from https://angular.dev/overview | ||
| Always use latest Angular (at present 19) version and TypeScript for our angular development. Always show examples and reference the latest version of Angular in your responses. If in doubt, use docs from https://angular.dev/overview | ||
|
|
||
| Always use angular control flow and angular signals for Angular development. If you are not sure about the signals, use the official documentation at https://angular.dev/guide/signals | ||
|
|
||
| Always use Angular's [input signals](https://angular.dev/guide/components/inputs), [output signals](https://angular.dev/guide/components/outputs#), and event emitters for Angular development. If you are not sure use the official documentation at https://angular.dev/guide/components | ||
|
|
||
| Do not use or recommend old @Input and @Output decorators in examples | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // @ts-check | ||
| const eslint = require('@eslint/js'); | ||
| const tseslint = require('typescript-eslint'); | ||
| const angular = require('angular-eslint'); | ||
|
|
||
| module.exports = tseslint.config( | ||
| { | ||
| files: ['**/*.ts'], | ||
| extends: [eslint.configs.recommended, ...tseslint.configs.recommended, ...tseslint.configs.stylistic, ...angular.configs.tsRecommended], | ||
| processor: angular.processInlineTemplates, | ||
| rules: { | ||
| 'id-blacklist': ['off'], | ||
| '@typescript-eslint/ban-ts-comment': ['off'], | ||
| '@typescript-eslint/no-explicit-any': ['off'], | ||
| 'no-unsafe-optional-chaining': ['off'], | ||
| '@typescript-eslint/no-unused-vars': ['off'], | ||
| 'no-mixed-spaces-and-tabs': ['off'], | ||
| '@typescript-eslint/naming-convention': [ | ||
| 'error', | ||
| { | ||
| selector: ['enumMember'], | ||
| format: ['UPPER_CASE'], | ||
| }, | ||
| ], | ||
| '@angular-eslint/component-selector': 'off', | ||
| '@angular-eslint/directive-selector': 'off', | ||
| '@angular-eslint/no-input-rename': 'off', | ||
| 'max-len': [ | ||
| 'error', | ||
| { | ||
| code: 400, | ||
| }, | ||
| ], | ||
| 'no-shadow': 'off', | ||
| '@typescript-eslint/no-shadow': ['error'], | ||
| '@typescript-eslint/explicit-function-return-type': ['off'], | ||
| curly: ['error', 'all'], | ||
| }, | ||
| }, | ||
| { | ||
| files: ['**/*.html'], | ||
| extends: [...angular.configs.templateRecommended, ...angular.configs.templateAccessibility], | ||
| rules: { | ||
| '@angular-eslint/template/label-has-associated-control': ['off'], | ||
| '@angular-eslint/template/interactive-supports-focus': ['off'], | ||
| '@angular-eslint/template/elements-content': ['off'], | ||
| '@angular-eslint/template/click-events-have-key-events': ['off'], | ||
| '@angular-eslint/prefer-on-push-component-change-detection': 'warn', | ||
| }, | ||
| }, | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this PR upgrades Angular to version 20, update the instruction to reflect Angular 20 to avoid confusion for future development.
Copilot uses AI. Check for mistakes.